-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Hubspot: fix "quotes" key error exception #10055
Source Hubspot: fix "quotes" key error exception #10055
Conversation
/test connector=connectors/source-hubspot
|
/test connector=connectors/source-hubspot
|
/test connector=connectors/source-hubspot
|
/test connector=connectors/source-hubspot
|
/test connector=connectors/source-hubspot
|
/test connector=connectors/source-hubspot
|
Codecov Report
@@ Coverage Diff @@
## master #10055 +/- ##
=========================================
Coverage ? 76.39%
=========================================
Files ? 5
Lines ? 610
Branches ? 0
=========================================
Hits ? 466
Misses ? 144
Partials ? 0 Continue to review full report at Codecov.
|
/publish connector=connectors/source-hubspot
|
What
Resolves #9334
quotes
stream will be added to the source connector only if credential type is API Key.When OAUTH credentials are used and
quotes
stream is chosen, calling this method fails, which is called in _read_streamHow
Check whether
quotes
stream exists in the client, if no the connector should skip this stream by overriding method_read_stream
inSourceHubspot
.Recommended reading order
source_hubspot/source.py
source-hubspot/unit_tests/test_client.py